This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD] Disable script_test_12 for powerpc
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Cc: Cary Coutant <ccoutant at gmail dot com>, Ian Lance Taylor <iant at google dot com>
- Date: Tue, 28 Jun 2016 15:42:09 +0930
- Subject: Re: [GOLD] Disable script_test_12 for powerpc
- Authentication-results: sourceware.org; auth=none
- References: <20160628060834 dot GE3665 at bubble dot grove dot modra dot org>
On Tue, Jun 28, 2016 at 03:38:34PM +0930, Alan Modra wrote:
> The linker script is way too x86-centric. Non-bss plt and 4k pages
> result in the executable segfaulting before _start is executed.
>
> OK to apply?
>
> * testsuite/Makefile.am (script_test_12): Disable for powerpc.
> (script_test_12i): Likewise.
> * testsuite/Makefile.in: Regenerate.
Changes necessary to make this test pass on powerpc64. For interest
really. I'm hesitant to apply this change so close to a release in
case it blows up on ARM or some other target. Passes on x86_64.
* script_test_12.t: Delete .plt, specify 64k page size.
* script_test_12i.t: Likewise.
diff --git a/gold/testsuite/script_test_12.t b/gold/testsuite/script_test_12.t
index 4579c58..d415d04 100644
--- a/gold/testsuite/script_test_12.t
+++ b/gold/testsuite/script_test_12.t
@@ -33,14 +33,13 @@ SECTIONS
.rel.plt : { *(.rel.plt) }
.rela.plt : { *(.rela.plt) }
.init : { *(.init) }
- .plt : { *(.plt) }
.text : { *(.text) }
.fini : { *(.fini) }
.rodata : { *(.rodata .rodata.*) }
.eh_frame_hdr : { *(.eh_frame_hdr) }
.eh_frame : { *(.eh_frame) }
- . = DATA_SEGMENT_ALIGN(0x1000, 0x1000);
+ . = DATA_SEGMENT_ALIGN(0x10000, 0x10000);
.init_array : {
__init_array_start = .;
diff --git a/gold/testsuite/script_test_12i.t b/gold/testsuite/script_test_12i.t
index af19cd6..6578f74 100644
--- a/gold/testsuite/script_test_12i.t
+++ b/gold/testsuite/script_test_12i.t
@@ -33,14 +33,13 @@ SECTIONS
.rel.plt : { *(.rel.plt) }
.rela.plt : { *(.rela.plt) }
.init : { *(.init) }
- .plt : { *(.plt) }
.text : { *(.text) }
.fini : { *(.fini) }
.rodata : { *(.rodata .rodata.*) }
.eh_frame_hdr : { *(.eh_frame_hdr) }
.eh_frame : { *(.eh_frame) }
- . = DATA_SEGMENT_ALIGN(0x1000, 0x1000);
+ . = DATA_SEGMENT_ALIGN(0x10000, 0x10000);
.init_array : {
__init_array_start = .;
--
Alan Modra
Australia Development Lab, IBM