This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] arc: prototype arc_get_mach in opcodes/arc.h
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Alan Modra <amodra at gmail dot com>
- Cc: tbsaunde+binutils at tbsaunde dot org, binutils at sourceware dot org
- Date: Mon, 27 Jun 2016 05:20:01 -0400
- Subject: Re: [PATCH] arc: prototype arc_get_mach in opcodes/arc.h
- Authentication-results: sourceware.org; auth=none
- References: <1466936519-27678-1-git-send-email-tbsaunde+binutils at tbsaunde dot org> <20160627015221 dot GC29913 at bubble dot grove dot modra dot org>
On Mon, Jun 27, 2016 at 11:22:21AM +0930, Alan Modra wrote:
> On Sun, Jun 26, 2016 at 06:21:59AM -0400, firstname.lastname@example.org wrote:
> > include/ChangeLog:
> > 2016-06-26 Trevor Saunders <email@example.com>
> > * opcode/arc.h (arc_get_mach): New prototype.
> This also is probably better put in a new bfd/elf32-arc.h, since it
> really doesn't have anything to do with opcodes.
sure, makes sense.
> There are also mechanisms to put prototypes into libfd.h (see
> INTERNAL_DEFINITION) or more appropriately in this case for a public
> function, bfd.h (FUNCTION/SYNOPSIS). I'm not a big fan of this scheme
> but if you wanted to use it to declare arc_get_mach rather than using
> a new header that would be OK too. Same goes for the dlx patch.
that's the doc/chew.c and doc/*.str stuff? lovely I think it'll be
easier to just add a new header, and maybe someday I'll ponder what to
replace that setup with.
> Alan Modra
> Australia Development Lab, IBM