This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][gold] Fix input sections ordering if a spec like "*(A B)" is used.

> An input section specification with more than one name template and
> without sorting instructions gathered all not yet processed input sections
> within its output section during the phase of setting addresses.

Thanks for finding this and for suggesting a fix.

I've fixed this a different way. Rather than setting
input_pattern_count to 1, I've added a new bin_count and used that
where appropriate, letting input_pattern_count remain a true count of
the input patterns. Also, simply adding an extra .x4 section to the
existing script_test_12 sources was sufficient to demonstrate the


2016-06-23  Cary Coutant  <>
            Igor Kudrin  <>

        PR gold/15370
        (Output_section_element_input::set_section_addresses): Keep bin_count
        separate from input_pattern_count.
        * testsuite/script_test_12.t: Add another section .x4.
        * testsuite/script_test_12i.t: Likewise.
        * testsuite/script_test_12a.c: Likewise.
        * testsuite/script_test_12b.c: Likewise.

Attachment: pr15370b.patch
Description: Binary data

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]