This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR ld/20283: ld: Add a linker configure option --enable-relro
- From: Nick Clifton <nickc at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org
- Date: Wed, 22 Jun 2016 09:17:44 +0100
- Subject: Re: [PATCH] PR ld/20283: ld: Add a linker configure option --enable-relro
- Authentication-results: sourceware.org; auth=none
- References: <20160621221033 dot GA19120 at intel dot com>
Hi H.J.
A couple of observations:
> +* Add a configure option --enable-relro to decide whether -z relro should
> + be enabled in ELF linker by default.
Please could you mention the default setting here (ie "on" for all Linux targets
except FRV, HPPA, IA64 and MIPS).
> diff --git a/ld/configure b/ld/configure
You know that you do not need to include the diffs in generated files like this one, right ?
> +# Decide if -z relro should be enabled in ELF linker by default.
> +ac_default_ld_z_relro=unset
> +# Provide a configure time option to override our default.
> +AC_ARG_ENABLE(relro,
> + AS_HELP_STRING([--enable-relro],
> + [enable -z relro in ELF linker by default]),
> +[case "${enableval}" in
> + no) ac_default_ld_z_relro=0 ;;
> +esac])dnl
I think that you ought to support --enable-relro=yes here as well.
Cheers
Nick