This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, binutils/ARM] Fix feature checks based on arch value and force review of logic for new arch

Hi Thomas,

   I have some regressions with your patch for a toolset configured for
armv6s-m architecture.
   I have now veneers generated whereas previously they were not
   This is due to the fact that using_thumb2() returns now 0 and
so triggers generation of veneers for branch offset between
   These veneers are useless for armv6s-m architecture since
it has support for 32-bit BL.

   I think a potential solution is to add a using_thumb2_bl() that
will return 1 for target that support 32-bit BL and use it
for veneer need detection.
   What do you think of such a solution ?

Best regards,

On 06/14/2016 01:05 PM, Thomas Preudhomme wrote:
On Friday 03 June 2016 09:42:55 Nick Clifton wrote:
Hi Thomas,

*** bfd/ChangeLog ***

2016-05-17  Thomas Preud'homme  <>

         * elf32-arm.c (using_thumb_only): Force review of arch check logic
         new architecture.
         (using_thumb2): Try Tag_THUMB_ISA_use first and check
         for exact arch value then.  Force review of arch check logic for
         (arch_has_arm_nop): Update and fix arch check logic.  Force review
         that logic for new architecture.
         (arch_has_thumb2_nop): Remove.
         (elf32_arm_tls_relax): Use using_thumb2 instead of above function.
         (elf32_arm_final_link_relocate): Likewise but using thumb2.

Approved - please apply.

Done, sorry for the delay.

Best regards,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]