This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Marcus, Thanks for the review. Please find the updated patch (attached with this mail) with vulcan name in alphabetical order. Also fixed the ChangeLog. Please review it. gas/ChangeLog: Virendra Pathak <virendra.pathak@broadcom.com> * config/tc-aarch64.c (aarch64_cpus): Add vulcan. * doc/c-aarch64.texi: Document that vulcan is a valid processor name. Thanks. with regards, Virendra Pathak On Wed, Jun 8, 2016 at 1:29 PM, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote: > On 8 June 2016 at 06:35, Virendra Pathak <virendra.pathak@broadcom.com> wrote: >> Hi Marcus, >> >> 1) I have attached the binutils patch in the first mail > > Hi, > > Thanks for the patch, I have a couple of minor comments: > > > + {"vulcan", AARCH64_FEATURE (AARCH64_ARCH_V8, > + AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO), > + "Broadcom Vulcan"}, > {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8, > > Please add vulcan in alphabetical order. > > @code{qdf24xx}, > +@code{vulcan}, > @code{thunderx}, > > Likewise. > >> 2) Added the author entry in the ChangeLog >> >> gas/ChangeLog: >> Virendra Pathak (virendra.pathak@broadcom.com) >> * config/tc-aarch64.c (aarch64_cpus): Add vulcan. > >> * doc/c-aarch64.texi : Document that vulcan is a valid processor name > > No space between before the ':', full stop at the end of the sentence. > > Thanks > /Marcus
Attachment:
0001-aarch64-add-vulcan-support-to-gas.patch.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |