This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][MIPS] Add support for P6600
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Robert Suchanek <Robert dot Suchanek at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 20 May 2016 15:02:33 +0100
- Subject: Re: [PATCH][MIPS] Add support for P6600
- Authentication-results: sourceware.org; auth=none
- References: <B5E67142681B53468FAF6B7C313565624F4EBE29 at hhmail02 dot hh dot imgtec dot org>
Hi Robert,
Apologies to have missed your patch. This is OK with the two formatting
nits below addressed, no need to repost. Also, since you'll be committing
on behalf of someone else, please ensure the right authorship attribution,
e.g. `git commit --author=...' -- apologies if you find this obvious.
> gas/ChangeLog:
>
> 2016-05-13 Matthew Fortune <matthew.fortune@imgtec.com>
>
> * config/tc-mips.c (mips_cpu_info_table): Update comment. Add
Two spaces after a full stop please.
> diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
> index b538ff0..f424307 100644
> --- a/gas/config/tc-mips.c
> +++ b/gas/config/tc-mips.c
> @@ -18745,8 +18745,9 @@ static const struct mips_cpu_info mips_cpu_info_table[] =
> MIPS64R2 rather than MIPS64. */
> { "xlp", 0, 0, ISA_MIPS64R2, CPU_XLR },
>
> - /* i6400. */
> + /* MIPS 64 Release 6 */
This is not a sentence, so just a single space at the end please, just as
with the remaining like comments across this struct.
Thank you for your contribution!
Maciej