This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, ppc] Allow IMM8 operands to accept both signed and unsigned values


On Wed, May 18, 2016 at 11:58:23PM -0600, Jan Beulich wrote:
> >>> Alan Modra <amodra@gmail.com> 05/19/16 6:50 AM >>>
> >+  /* The NSI field in a D form instruction when we accept a wide range
> >+     of positive values.  */
> >+#define NSISIGNOPT NSI + 1
> >+  { 0xffff, 0, NULL, NULL,
> >+    PPC_OPERAND_NEGATIVE | PPC_OPERAND_SIGNED | PPC_OPERAND_SIGNOPT },
>  
> Does this work without using an insertion function negating the intended value
> (as it looks re-using {insert,extract}_nsi() should be okay)?

Oops, indeed.  Fixed with the obvious change to use insert/extract.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]