This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH ARC 1/3]: BFD fixes
- From: Nick Clifton <nickc at redhat dot com>
- To: Cupertino Miranda <Cupertino dot Miranda at synopsys dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, Francois Bedard <Francois dot Bedard at synopsys dot com>
- Date: Wed, 18 May 2016 12:21:39 +0100
- Subject: Re: [PATCH ARC 1/3]: BFD fixes
- Authentication-results: sourceware.org; auth=none
- References: <EB86EB452ADE4B44B294F7149B8A2777021B4DEF at DE02WEMBXB dot internal dot synopsys dot com>
Hi Cupertino,
> Cupertino Miranda <cmiranda@synopsys.com>
> elf32-arc.c (arc_elf_final_write_processing): Changed.
> (debug_arc_reloc): Likewise.
> (elf_arc_relocate_section): Likewise.
> (elf_arc_check_relocs): Likewise.
> (elf_arc_adjust_dynamic_symbol): Likewise.
> (elf_arc_add_symbol_hook): Likewise.
Approved - please apply, but...
@@ -1180,10 +1185,10 @@ elf_arc_relocate_section (bfd * output_bfd,
);
}
}
-
- continue;
}
+
+
h2 = elf_link_hash_lookup (elf_hash_table (info), "__SDATA_BEGIN__",
FALSE, FALSE, TRUE);
@@ -1203,6 +1208,7 @@ elf_arc_relocate_section (bfd * output_bfd,
reloc_data.reloc_offset = rel->r_offset;
reloc_data.reloc_addend = rel->r_addend;
+
/* This is a final link. */
h = NULL;
sym = NULL;
Are these extra blank lines really needed ?
Cheers
Nick