This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed, PATCH] PR ld/20097: Remove redundant sizeof on EXPECTED_VIEW_LENGTH
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Date: Sat, 14 May 2016 05:52:53 -0700
- Subject: [committed, PATCH] PR ld/20097: Remove redundant sizeof on EXPECTED_VIEW_LENGTH
- Authentication-results: sourceware.org; auth=none
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
PR ld/20097
* testplug2.c (onall_symbols_read): Remove redundant sizeof
on EXPECTED_VIEW_LENGTH.
* testplug4.c (onall_symbols_read): Likewise.
---
ld/ChangeLog | 7 +++++++
ld/testplug2.c | 2 +-
ld/testplug4.c | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 13f8c0b..291c751 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,10 @@
+2016-05-14 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/20097
+ * testplug2.c (onall_symbols_read): Remove redundant sizeof
+ on EXPECTED_VIEW_LENGTH.
+ * testplug4.c (onall_symbols_read): Likewise.
+
2016-05-13 H.J. Lu <hongjiu.lu@intel.com>
PR ld/20093
diff --git a/ld/testplug2.c b/ld/testplug2.c
index 5e34643..5dc4e78 100644
--- a/ld/testplug2.c
+++ b/ld/testplug2.c
@@ -602,7 +602,7 @@ onall_symbols_read (void)
#define EXPECTED_VIEW "/* The first line of this file must match the expectation of"
#define EXPECTED_VIEW_LENGTH (sizeof (EXPECTED_VIEW) - 1)
if (file.filesize != SIZE_OF_FUNC_C
- || SIZE_OF_FUNC_C < sizeof EXPECTED_VIEW_LENGTH
+ || SIZE_OF_FUNC_C < EXPECTED_VIEW_LENGTH
|| memcmp (view, EXPECTED_VIEW, EXPECTED_VIEW_LENGTH) != 0)
{
char result[EXPECTED_VIEW_LENGTH + 1];
diff --git a/ld/testplug4.c b/ld/testplug4.c
index fe7665a..86bad65 100644
--- a/ld/testplug4.c
+++ b/ld/testplug4.c
@@ -608,7 +608,7 @@ onall_symbols_read (void)
#define EXPECTED_VIEW "/* The first line of this file must match the expectation of"
#define EXPECTED_VIEW_LENGTH (sizeof (EXPECTED_VIEW) - 1)
if (file.filesize != SIZE_OF_PR20070B_C
- || SIZE_OF_PR20070B_C < sizeof EXPECTED_VIEW_LENGTH
+ || SIZE_OF_PR20070B_C < EXPECTED_VIEW_LENGTH
|| memcmp (view, EXPECTED_VIEW, EXPECTED_VIEW_LENGTH) != 0)
{
char result[EXPECTED_VIEW_LENGTH + 1];
--
2.5.5