This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC PATCH, binutils, ARM 4/11, ping] Use getters/setters to access ARM branch type
- From: Nick Clifton <nickc at redhat dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 9 May 2016 12:21:14 +0100
- Subject: Re: [RFC PATCH, binutils, ARM 4/11, ping] Use getters/setters to access ARM branch type
- Authentication-results: sourceware.org; auth=none
- References: <004c01d13d57$975ae2a0$c610a7e0$ at foss dot arm dot com> <32442566 dot GSo4DN4Amp at e108577-lin> <57038DDD dot 9090401 at redhat dot com> <3372682 dot LT612JpDFC at e108577-lin>
Hi Thomas,
> Quite verbose and dynamic checking only but I could not find anything better
> indeed. I just removed the use of a variable in the setters.
Fair enough.
> *** bfd/ChangeLog ***
> 2015-12-16 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * elf32-arm.c (elf32_arm_size_stubs): Use new macros
> ARM_GET_SYM_BRANCH_TYPE and ARM_SET_SYM_BRANCH_TYPE to respectively
> get
> and set branch type of a symbol.
> (bfd_elf32_arm_process_before_allocation): Likewise.
> (elf32_arm_relocate_section): Likewise and fix identation along the
> way.
> (allocate_dynrelocs_for_symbol): Likewise.
> (elf32_arm_finish_dynamic_symbol): Likewise.
> (elf32_arm_swap_symbol_in): Likewise.
> (elf32_arm_swap_symbol_out): Likewise.
>
>
> *** gas/ChangeLog ***
> 2015-12-16 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * config/tc-arm.c (arm_adjust_symtab): Use ARM_SET_SYM_BRANCH_TYPE to
> set branch type of a symbol.
Approved - please apply.
> *** gdb/ChangeLog ***
> 2015-12-16 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * arm-tdep.c (arm_elf_make_msymbol_special): Use
> ARM_GET_SYM_BRANCH_TYPE to get branch type of a symbol.
You will have to get approval from the GDB project for this...
> *** include/elf/ChangeLog ***
> 2016-04-12 Thomas Preud'homme <thomas.preudhomme@arm.com>
> Nick Clifton <nickc@redhat.com>
>
> * arm.h (enum arm_st_branch_type): Add new ST_BRANCH_ENUM_SIZE
> enumerator.
> (NUM_ENUM_ARM_ST_BRANCH_TYPE_BITS): New macro.
> (ENUM_ARM_ST_BRANCH_TYPE_BITMASK): Likewise.
> (ARM_SYM_BRANCH_TYPE): Replace by ...
> (ARM_GET_SYM_BRANCH_TYPE): This and ...
> (ARM_SET_SYM_BRANCH_TYPE): This in two versions depending on whether
> BFD_ASSERT is defined or not.
>
>
> *** ld/ChangeLog ***
> 2015-12-16 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> (gld${EMULATION_NAME}_finish): Use ARM_GET_SYM_BRANCH_TYPE to get
> branch type of a symbol.
>
>
> *** opcodes/ChangeLog ***
> 2015-12-16 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * arm-dis.c (get_sym_code_type): Use ARM_GET_SYM_BRANCH_TYPE to get
> branch type of a symbol.
> (print_insn): Likewise.
Approved - please apply.
Cheers
Nick