This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- From: Nick Clifton <nickc at redhat dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>, binutils at sourceware dot org
- Date: Fri, 6 May 2016 17:43:48 +0100
- Subject: Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1605032355130 dot 6794 at tp dot orcam dot me dot uk> <alpine dot DEB dot 2 dot 00 dot 1605040010060 dot 6794 at tp dot orcam dot me dot uk>
> So does anybody actually know why the current per-architecture approach
> was accepted in the review?
No. My guess is that it was not thought through properly. Possibly a
developer wanted it for their architecture, but did not consider the impact
on other architectures. So their patch went in for their architecture and
the feature proved to be useful. Then users for other architectures (probably
kernel and library builders) decided that they wanted it too, and so a
piecemeal set of hacks were added to accommodate them. Just a guess mind...
> If not then I'll post a proposal separately to gather all the bits
> scattered across target `*_add_symbol_hook' handlers and handle this
> feature in `elf_link_add_object_symbols'.