This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- From: Pedro Alves <palves at redhat dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 4 May 2016 17:54:23 +0100
- Subject: Re: [PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1605032355130 dot 6794 at tp dot orcam dot me dot uk> <alpine dot DEB dot 2 dot 00 dot 1605040010060 dot 6794 at tp dot orcam dot me dot uk> <6D39441BF12EF246A7ABCE6654B023537E3F7E91 at hhmail02 dot hh dot imgtec dot org> <alpine dot DEB dot 2 dot 00 dot 1605041509120 dot 6794 at tp dot orcam dot me dot uk>
On 05/04/2016 03:20 PM, Maciej W. Rozycki wrote:
> though, or maybe even make another De Morgan transformation and have a
> single negation at the then outermost level. Keeping the `*-*-elf*'
> exceptions on a single line might improve readability, although it'll be
> lost with the first addition of another exception.
Or add a proc, which then allows early returns, making it
more readable, IMO:
proc supports_gnu_unique {} {
# Only ELF.
if {!([istarget "*-*-elf*"]
|| [istarget *-*-nacl*]
|| [istarget *-*-linux*]
|| [istarget *-*-gnu*]) } {
return 0
}
# These targets set the ELF header's OSABI field to
# ELFOSABI_STANDALONE and cannot support STB_GNU_UNIQUE.
if {[istarget "msp430-*-*"]
|| [istarget "visium-*-*"]} {
return 0
}
# Default to yes.
return 1
}
...
if { ![supports_gnu_unique] } {
verbose "UNIQUE tests not run - target does not support UNIQUE"
return
}
...
Thanks,
Pedro Alves