This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 0/2] [PUSHED/OBV] gas/arc: Add nps400 support to .cpu directive
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Claudiu Zissulescu <claziss at gmail dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, Binutils <binutils at sourceware dot org>, Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, Cupertino Miranda <Cupertino dot Miranda at synopsys dot com>
- Date: Sun, 17 Apr 2016 21:35:17 +0100
- Subject: Re: [PATCH 0/2] [PUSHED/OBV] gas/arc: Add nps400 support to .cpu directive
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1460822027 dot git dot andrew dot burgess at embecosm dot com> <CAL0iMy1eDXHNYZS_B=zNvV+FMnp09yPHo2gxYLTiHEYgk=LG+A at mail dot gmail dot com>
* Claudiu Zissulescu <email@example.com> [2016-04-17 10:35:16 +0200]:
> I am not sure if those two patches are obvious. One is changing the
> semantic of a pseudo-op. I would expect a bit of discussion here, as
> in our ARC backend R0 is a symbol while r0 is a register. Hence, we
> are case sensitive. And the other one adds (doesn't fix) a new
I apologise if I have overstepped the mark with these commits.
The change in case sensitivity brings the '.cpu' directive into line
with the -mcpu command line option.
Claudiu, you make it clear in the above that you _could_ object to
this commit, however, even after reading the above a couple of times,
it's not clear if you are actually objecting or not. If you don't
like the commit then please make an objection, the commit can always
You are right that adding support for nps400 to the .cpu directive is
not a bug fix, however, the code is trivial, follow the existing
pattern of code in that function, and given that nps400 has been
accepted I am curious under what situation you think that that part of
the commit would be objected to in any way?
Again, I apologise if anyone feels I was too forward in pushing these
patches, I certainly did not intend to cause any offence.
> Nick should be the one if I am right or not.
> On Sat, Apr 16, 2016 at 6:01 PM, Andrew Burgess
> <firstname.lastname@example.org> wrote:
> > Two patches that I've pushed relating to adding support for nps400 to
> > the ARC assembler .cpu directive. The first patch adds support for
> > nps400 while the second makes the .cpu directive case-insensitive.
> > I've pushed both of these fixes as obvious.
> > ---
> > Andrew Burgess (2):
> > gas/arc: Support NPS400 in .cpu directive
> > gas/arc: Make .cpu directive case-insensitive
> > gas/ChangeLog | 9 +++++++++
> > gas/config/tc-arc.c | 18 +++++++++++-------
> > 2 files changed, 20 insertions(+), 7 deletions(-)
> > --
> > 2.6.4