This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH 1/3] opcodes/arc: Compute insn lengths in disassembler
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Cupertino dot Miranda at synopsys dot com" <Cupertino dot Miranda at synopsys dot com>, "noamca at mellanox dot com" <noamca at mellanox dot com>
- Date: Thu, 7 Apr 2016 11:27:45 +0000
- Subject: RE: [PATCH 1/3] opcodes/arc: Compute insn lengths in disassembler
- Authentication-results: sourceware.org; auth=none
- References: <1460027127-1121-1-git-send-email-andrew dot burgess at embecosm dot com> <1460027127-1121-2-git-send-email-andrew dot burgess at embecosm dot com>
Hi,
> +static int
> +arc_insn_length (unsigned isa_mask, bfd_byte msb,
> + bfd_byte lsb ATTRIBUTE_UNUSED)
> +{
> + static int tbl [32]; /* 0x00 -> 0x1f */
> + static int tbl_init = 0;
Please use bfd_boolean instead of int for tbl_init.
Otherwise, it seems sane to me.
Best,
Claudiu