This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v4] gold: Add Mips64 support.
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Vladimir Radosavljevic <Vladimir dot Radosavljevic at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Thu, 17 Mar 2016 14:36:29 -0700
- Subject: Re: [PATCH v4] gold: Add Mips64 support.
- Authentication-results: sourceware.org; auth=none
- References: <3060420525346945A0ADBD567348A91723740827 at BADAG02 dot ba dot imgtec dot org> <CAJimCsHMz-ZkiTRdJtf3=EF3KzZ0o5190nJpcuYfvZECVZ7JYw at mail dot gmail dot com> <3060420525346945A0ADBD567348A91723740AE3 at BADAG02 dot ba dot imgtec dot org>
>> + if (section_type == elfcpp::SHT_NOBITS)
>> + return false;
>> +
>> + if (section_flags & elfcpp::SHF_WRITE)
>> + return false;
>>
>> Just out of curiosity... Why would a NOBITS section ever not have
>> SHF_WRITE set? Is there any reason to test for NOBITS?
>
> I've added a check for NOBITS section only to follow LLD and GNU LD linkers. Do you want me to remove that?
No, it's OK. I was just curious.
-cary