This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: ARM breakage with "[PATCH 3/4] allow targets to call do_alignment () directly"
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: tbsaunde+binutils at tbsaunde dot org, binutils at sourceware dot org
- Date: Tue, 8 Mar 2016 19:59:44 -0500
- Subject: Re: ARM breakage with "[PATCH 3/4] allow targets to call do_alignment () directly"
- Authentication-results: sourceware.org; auth=none
- References: <1457233818-6697-4-git-send-email-tbsaunde+binutils at tbsaunde dot org> <201603081958 dot u28JwfRG016311 at ignucius dot se dot axis dot com>
On Tue, Mar 08, 2016 at 08:58:41PM +0100, Hans-Peter Nilsson wrote:
> > From: tbsaunde+binutils@tbsaunde.org
> > Date: Sat, 5 Mar 2016 22:10:17 -0500
>
> > gas/ChangeLog:
> >
> > 2016-03-05 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
> >
> > * config/tc-epiphany.c (epiphany_elf_section_rtn): Call do_align
> > directly.
> > (epiphany_elf_section_text): Likewise.
> > * gas/config/tc-ip2k.c (ip2k_elf_section_rtn): Likewise.
> > (ip2k_elf_section_text): Likewise.
> > * gas/read.c (do_align): Make it not static.
> > * gas/read.h (do_align): New prototype.
>
> Not sure why neither you nor anyone else seems to have seen
> this, but my autotester sees this, building arm-eabi and
> arm-linux-eabi:
I was able to reproduce this with gcc 4.7. Apparently it warns about
shadowing in
int foo(void);
int bar(int foo) { return 0; }
but 4.8 and 4.9 don't.
> gcc -O2 -m32 -DHAVE_CONFIG_H -I. -I/tmp/hpautotest-binutils/bsrc/src/gas -I. -I/tmp/hpautotest-binutils/bsrc/src/gas -I../bfd -I/tmp/hpautotest-binutils/bsrc/src/gas/config -I/tmp/hpautotest-binutils/bsrc/src/gas/../include -I/tmp/hpautotest-binutils/bsrc/src/gas/.. -I/tmp/hpautotest-binutils/bsrc/src/gas/../bfd -DLOCALEDIR="\"/usr/local/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -I/tmp/hpautotest-binutils/bsrc/src/gas/../zlib -g -O2 -MT tc-arm.o -MD -MP -MF .deps/tc-arm.Tpo -c -o tc-arm.o `test -f 'config/tc-arm.c' || echo '/tmp/hpautotest-binutils/bsrc/src/gas/'`config/tc-arm.c
> /tmp/hpautotest-binutils/bsrc/src/gas/config/tc-arm.c: In function 'neon_alignment_bit':
> /tmp/hpautotest-binutils/bsrc/src/gas/config/tc-arm.c:16678:47: error: declaration of 'do_align' shadows a global declaration [-Werror=shadow]
> In file included from /tmp/hpautotest-binutils/bsrc/src/gas/as.h:557:0,
> from /tmp/hpautotest-binutils/bsrc/src/gas/config/tc-arm.c:26:
> /tmp/hpautotest-binutils/bsrc/src/gas/read.h:156:13: error: shadowed declaration is here [-Werror=shadow]
> /tmp/hpautotest-binutils/bsrc/src/gas/config/tc-arm.c: In function 'do_neon_ld_st_lane':
> /tmp/hpautotest-binutils/bsrc/src/gas/config/tc-arm.c:16717:19: error: declaration of 'do_align' shadows a global declaration [-Werror=shadow]
>
> Please fix.
I'm testing a patch now.
Trev
>
> brgds, H-P