This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR ld/19636: [x86] Resolve undefweak and defined symbols in executable


>
> Well, then why you put it under generic directory? and without restricting
> it
> on x86?

Hang on Jiong - seeing the failure on other targets is fine -
technically other targets need to know if they are broken or not, the
best way of getting attention is a FAIL.

regards
Ramana

>
> IMO, the support of weak symbol under various rare and complex scenarios are
> very
> target specific, thus I'd either move this testcase under x86 directory or
> put it under
> generic directory but enabling it on x86 only initially.  If other targets
> want and start
> to support similar features like x86 on weak symbol, then they can be
> enabled seperately.
> This looks to me is a more clean & acceptable way to other targets.
>
> Thanks.
>
> Regards,
> Jiong


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]