This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] split up epiphany's md_assemble ()


On Sun, Feb 28, 2016 at 03:01:07PM -0500, tbsaunde+binutils@tbsaunde.org wrote:
> 	* gas/config/tc-epiphany.c (md_assemble): Adjust.
> 	(epiphany_assemble): New function.

OK, but

> +static void
> +  epiphany_assemble (const char *str)
> +    {

please fix the formatting here, and move md_assemble after
epiphany_assemble so the forward declaration is not needed.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]