This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 0/6] misc constification of strings
- From: Nick Clifton <nickc at redhat dot com>
- To: Trevor Saunders <tbsaunde at tbsaunde dot org>
- Cc: tbsaunde+binutils at tbsaunde dot org, binutils at sourceware dot org
- Date: Fri, 19 Feb 2016 16:28:36 +0000
- Subject: Re: [PATCH 0/6] misc constification of strings
- Authentication-results: sourceware.org; auth=none
- References: <1455681262-11896-1-git-send-email-tbsaunde+binutils at tbsaunde dot org> <56C704DE dot 3030204 at redhat dot com> <20160219135546 dot GB8906 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com>
> thanks, from rebasing some other patches it looks like making the local
> "string" in s_stab_generic () const got dropped, was that intended?
Sorry - snafu - now fixed.
> I also se you made some whitespace fixups, are the rules documented
Not specifically with regard to whitespace and C types no. In generic we
try to adhere to the GNU Coding Standards, but that does not define how
types and variable names are separated. I personally feel that there
should be at least one whitespace character between the type name and the
variable name, even if that type is a pointer. (IE "char * foo;"). But
many other people treat the asterisk as part of the variable name, when
declaring the type. (IE: "char *foo;").