This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/6] misc constification of strings


On Fri, Feb 19, 2016 at 12:04:46PM +0000, Nick Clifton wrote:
> Hi Trevor,
> 
> > It generaly seems like a good idea to make things const when possible,
> > especially when we sometimes make them point to literals.
> > 
> > patches individually built and tested on x86_64-linux-gnu, ok?
> 
> Approved and applied (all 6 patches).

thanks, from rebasing some other patches it looks like making the local
"string" in s_stab_generic () const got dropped, was that intended?

I also se you made some whitespace fixups, are the rules documented
somewhere?

thanks!

Trev

> 
> Cheers
>   Nick
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]