This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Commit: Fix

Hi Guys,

  I am applying the patch below to fix this compile time warning from
  newer versions of gcc:

    gas/config/tc-ia64.c: In function 'dot_prologue':
    gas/config/tc-ia64.c:4363:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
        n = popcount (mask);
    gas/config/tc-ia64.c:4361:7: note: ...this 'else' clause, but it is not

  It turns out that the warning is correct, the programmer probably did
  intend for the else clause to guard the calculation.  But it is safer
  to always compute n, even if the mask is zero, so I have left the code
  the way it was, just with the formatting fixed.


2016-02-08  Nick Clifton  <>

	* config/tc-ia64.c (dot_prologue): Fix formatting.

diff --git a/gas/config/tc-ia64.c b/gas/config/tc-ia64.c
index 570f746..e00b8e1 100644
--- a/gas/config/tc-ia64.c
+++ b/gas/config/tc-ia64.c
@@ -4360,7 +4360,8 @@ dot_prologue (int dummy ATTRIBUTE_UNUSED)
 	as_warn (_("Pointless use of zero first operand to .prologue"));
 	mask = e.X_add_number;
-	n = popcount (mask);
+      n = popcount (mask);
       if (sep == ',')
 	parse_operand_and_eval (&e, 0);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]