This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[gold commit] PR 19577: Fix build failure in gold due to signed vs. unsigned comparisons
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Binutils <binutils at sourceware dot org>
- Date: Sat, 6 Feb 2016 09:56:39 -0800
- Subject: [gold commit] PR 19577: Fix build failure in gold due to signed vs. unsigned comparisons
- Authentication-results: sourceware.org; auth=none
I've committed this trivial patch to fix a build failure.
-cary
2016-02-06 Cary Coutant <ccoutant@gmail.com>
gold/
PR gold/19577
* reloc.h (Bits::has_unsigned_overflow32): Fix unsigned/signed
comparison.
(Bits::has_unsigned_overflow): Likewise.
diff --git a/gold/reloc.h b/gold/reloc.h
index 4f1e753..fce7313 100644
--- a/gold/reloc.h
+++ b/gold/reloc.h
@@ -1015,7 +1015,7 @@ class Bits
gold_assert(bits > 0 && bits <= 32);
if (bits == 32)
return false;
- int32_t max = static_cast<int32_t>((1U << bits) - 1);
+ uint32_t max = static_cast<int32_t>((1U << bits) - 1);
return val > max;
}
@@ -1081,7 +1081,7 @@ class Bits
gold_assert(bits > 0 && bits <= 64);
if (bits == 64)
return false;
- int64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) << bits) - 1);
+ uint64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) <<
bits) - 1);
return val > max;
}