This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] xtensa: fix signedness of gas relocations
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- Cc: binutils at sourceware dot org, David Weatherford <weath at cadence dot com>, Marc Gauthier <marc at cadence dot com>, "linux-xtensa at linux-xtensa dot org" <linux-xtensa at linux-xtensa dot org>
- Date: Wed, 3 Feb 2016 20:48:36 +0300
- Subject: Re: [PATCH] xtensa: fix signedness of gas relocations
- Authentication-results: sourceware.org; auth=none
- References: <1454488597-27699-1-git-send-email-jcmvbkbc at gmail dot com> <CAGSvup9+81dikr8oJZZt=7c6jhTwTfmircfbzxurPMWk4oOWVA at mail dot gmail dot com>
On Wed, Feb 3, 2016 at 8:47 PM, augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
> On Wed, Feb 3, 2016 at 12:36 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> Change 1058c7532d0b "Use signed data type for R_XTENSA_DIFF* relocation
>> offsets." changed signedness of BFD_RELOC_XTENSA_DIFF* relocations
>> substituted for BFD_RELOC_*. This made it impossible to encode arbitrary
>> 8-, 16- and 32-bit values, which broke e.g. debug info encoding by .loc
>> directive. Revert this part and add test.
>>
>> gas/
>> 2016-02-03 Max Filippov <jcmvbkbc@gmail.com>
>> * config/tc-xtensa.c (md_apply_fix): Mark BFD_RELOC_XTENSA_DIFF*
>> substitutions for BFD_RELOC_* as unsigned.
>>
>> gas/testsuite/
>> 2016-02-03 Max Filippov <jcmvbkbc@gmail.com>
>> * gas/xtensa/all.exp: Add loc to list of xtensa tests.
>> * gas/xtensa/loc.d: New file: loc test result patterns.
>> * gas/xtensa/loc.s: New file: loc test.
>
> This is OK.
Thanks. Checked in.
-- Max