This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Commit: Skip linker plugin tests if the linker is not configured to support them
- From: Nick Clifton <nickc at redhat dot com>
- To: binutils at sourceware dot org
- Date: Mon, 18 Jan 2016 11:22:42 +0000
- Subject: Commit: Skip linker plugin tests if the linker is not configured to support them
- Authentication-results: sourceware.org; auth=none
Hi Guys,
The other day I accidentally configured a Linux native linker without
--enable-plugins specified. When I ran the linker tests I encountered
a whole lot of unexpected failures in the ld-plugins/plugins.exp
directory because of the lack of plugin support. So I am checking in
the patch below (mainline and 2.26 branch) so skip the plugin tests
when plugins are not supported.
Cheers
Nick
ld/ChangeLog
2016-01-18 Nick Clifton <nickc@redhat.com>
* ld-plugin/plugin.exp: Skip plugin tests if the linker is not
configured to support plugins.
diff --git a/ld/testsuite/ld-plugin/plugin.exp b/ld/testsuite/ld-plugin/plugin.exp
index 64f4079..a8b0e4a 100644
--- a/ld/testsuite/ld-plugin/plugin.exp
+++ b/ld/testsuite/ld-plugin/plugin.exp
@@ -39,6 +39,12 @@ global base_dir
# Look for the name we can dlopen in the test plugin's libtool control script.
set plugin_name [file_contents "$base_dir/libldtestplug.la"]
set plugin_name [regsub "'.*" [regsub ".*dlname='" "$plugin_name" ""] ""]
+# Even though the API supports plugins it does not mean that the
+# linker was configured with --enable-plugins. Check for that here.
+if { $plugin_name == "" } {
+ verbose "The linker is not configured to support plugins"
+ return
+}
verbose "plugin name is '$plugin_name'"
set plugin2_name [file_contents "$base_dir/libldtestplug2.la"]