This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GAS][ARM] Autodetection tests
- From: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
- To: Thomas Preud'homme <thomas dot preudhomme at foss dot arm dot com>, binutils at sourceware dot org
- Date: Wed, 23 Dec 2015 15:10:01 +0000
- Subject: Re: [PATCH][GAS][ARM] Autodetection tests
- Authentication-results: sourceware.org; auth=none
- References: <002501d13878$f5eaece0$e1c0c6a0$ at foss dot arm dot com>
On 17/12/15 03:13, Thomas Preud'homme wrote:
> [Sending on behalf of Andre Vieira]
>
> Hi,
>
> This patch adds tests for gas' auto detection by checking the build attributes assigned to object files. These should correspond to the instructions original source as per: 'ARM Architecture Reference Manual ARMv7-A and ARMv7-R edition' found at: http://infocenter.arm.com/help/topic/com.arm.doc.ddi0406c/index.html
>
> This is correct because for these instructions, the architecture that first implements these is represented by the assigned build attributes. There are three exceptions here, CLREX, LDREXB and LDREXD. These instructions should be assigned attributes to represent ARMv7 and not ARMv6T2. The tests were left describing the current behavior, to detect any change, potentially pending a fix.
>
> Tested by running GAS regressions.
>
> Is this OK to commit?
>
> Thanks,
> Andre Vieira
>
> gas/testsuite/ChangeLog:
> 2015-12-09 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * gas/arm/automatic-bw.d: New.
> * gas/arm/automatic-bw.s: New.
> * gas/arm/automatic-cbz.d: New.
> * gas/arm/automatic-cbz.s: New.
> * gas/arm/automatic-clrex.d: New.
> * gas/arm/automatic-clrex.s: New.
> * gas/arm/automatic-lda.d: New.
> * gas/arm/automatic-lda.s: New.
> * gas/arm/automatic-ldaex.d: New.
> * gas/arm/automatic-ldaex.s: New.
> * gas/arm/automatic-ldaexb.d: New.
> * gas/arm/automatic-ldaexb.s: New.
> * gas/arm/automatic-ldrex.d: New.
> * gas/arm/automatic-ldrex.s: New.
> * gas/arm/automatic-ldrexd.d: New.
> * gas/arm/automatic-ldrexd.s: New.
> * gas/arm/automatic-movw.d: New.
> * gas/arm/automatic-movw.s: New.
> * gas/arm/automatic-sdiv.d: New.
> * gas/arm/automatic-sdiv.s: New.
> * gas/arm/automatic-strexb.d: New.
> * gas/arm/automatic-strexb.s: New.
>
>
OK.
R.