This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
And with the patch... -cary On Sun, Dec 13, 2015 at 2:42 PM, Cary Coutant <ccoutant@gmail.com> wrote: >> Thanks for the patches! I've updated mine, and the changes are now limitted >> to s390-specific code. The output_view patch has a minor problem: it >> returns a const unsigned char *, but I need a read-write view (I have to >> bump the frame size in the parameter block). I've just const_casted around >> it for now, but I suppose we should change the return type instead? > > Oops, sorry! I've committed the attached patch to remove the const. > > 2015-12-13 Cary Coutant <ccoutant@gmail.com> > > * object.h (Object::get_output_view): remove const from return type. > (Object::do_get_output_view): Likewise. > (Sized_relobj_file::do_get_output_view): Likewise. > * reloc.cc (Sized_relobj_file::do_get_output_view): Likewise. > >> Also, I still have an icky static_cast in the "find parameter block" >> sequence. but I suppose it's here to stay: >> >> + Sized_relobj_file<size, true> *object_sized = >> + static_cast<Sized_relobj_file<size, true> *>(object); > > Yes, we have a few other similar casts. It's not a high priority, but > I'll eventually see about adding a virtual function to the Object > class to return a Sized_relobj_file pointer to itself. > >> Btw, this patch shouldn't be landing yet, I still have to finish the gcc >> side. > > No problem; let me know when it's ready. > > -cary
Attachment:
get-output-view.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |