This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] gas: don't get confused by .asci{i,z} after .struct
- From: Alan Modra <amodra at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 8 Dec 2015 09:06:30 +1030
- Subject: Re: [PATCH 1/2] gas: don't get confused by .asci{i,z} after .struct
- Authentication-results: sourceware.org; auth=none
- References: <5665A8B002000078000BCAAB at prv-mh dot provo dot novell dot com>
On Mon, Dec 07, 2015 at 07:41:36AM -0700, Jan Beulich wrote:
> --- 2015-12-07/gas/read.c
> +++ 2015-12-07/gas/read.c
> @@ -5329,8 +5329,9 @@ stringer (int bits_appendzero)
> if (now_seg == absolute_section)
> {
> as_bad (_("strings must be placed into a section"));
> - c = 0;
> - ignore_rest_of_line ();
> + if (c)
> + ignore_rest_of_line ();
> + return;
> }
I think it would be better to move this block above the code setting
'c' (and of course not test 'c'). OK with that change.
--
Alan Modra
Australia Development Lab, IBM