This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] MIPS/GAS/testsuite: Tighten negative-match NaN tests


Fix a test quality regression introduced with commit 351cdf24 [[MIPS] 
Implement O32 FPXX, FP64 and FP64A ABI extensions] where MIPS ABI flags 
match patterns have been added to negative-match tests covering ELF file 
header flags.  Negative-match tests succeed whenever there is a failure 
in matching output produced and consequently the likelihood of a false 
success increases when patterns to match irrelevant output are added.

Therefore remove the irrelevant paterns so that the tests complete as 
soon as the line concerned has been seen.

	gas/testsuite/
	* gas/mips/nan-legacy-1.d: Remove MIPS ABI flags match patterns.
	* gas/mips/nan-legacy-2.d: Likewise.
	* gas/mips/nan-legacy-3.d: Likewise.
	* gas/mips/nan-legacy-4.d: Likewise.
	* gas/mips/nan-legacy-5.d: Likewise.
---
Tested against the usual set of targets, no regressions.

OK to apply?

  Maciej

binutils-mips-gas-test-nan-fix.diff
Index: binutils/gas/testsuite/gas/mips/nan-legacy-1.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/nan-legacy-1.d	2015-06-25 10:49:58.000000000 +0100
+++ binutils/gas/testsuite/gas/mips/nan-legacy-1.d	2015-06-25 10:51:00.833568396 +0100
@@ -5,17 +5,4 @@
 .*:.*file format.*mips.*
 #failif
 private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
-	None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
Index: binutils/gas/testsuite/gas/mips/nan-legacy-2.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/nan-legacy-2.d	2015-06-25 10:49:58.000000000 +0100
+++ binutils/gas/testsuite/gas/mips/nan-legacy-2.d	2015-06-25 10:51:09.871938033 +0100
@@ -6,17 +6,4 @@
 .*:.*file format.*mips.*
 #failif
 private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
-	None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
Index: binutils/gas/testsuite/gas/mips/nan-legacy-3.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/nan-legacy-3.d	2015-06-25 10:49:58.000000000 +0100
+++ binutils/gas/testsuite/gas/mips/nan-legacy-3.d	2015-06-25 10:51:15.560226222 +0100
@@ -5,17 +5,4 @@
 .*:.*file format.*mips.*
 #failif
 private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
-	None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
Index: binutils/gas/testsuite/gas/mips/nan-legacy-4.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/nan-legacy-4.d	2015-06-25 10:49:58.000000000 +0100
+++ binutils/gas/testsuite/gas/mips/nan-legacy-4.d	2015-06-25 10:51:20.970495958 +0100
@@ -6,17 +6,4 @@
 .*:.*file format.*mips.*
 #failif
 private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
-	None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass
Index: binutils/gas/testsuite/gas/mips/nan-legacy-5.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/nan-legacy-5.d	2015-06-25 10:49:58.000000000 +0100
+++ binutils/gas/testsuite/gas/mips/nan-legacy-5.d	2015-06-25 10:51:26.490970907 +0100
@@ -5,17 +5,4 @@
 .*:.*file format.*mips.*
 #failif
 private flags = [0-9a-f]*[4-7c-f]..: .*[[]nan2008[]].*
-
-MIPS ABI Flags Version: 0
-
-ISA: MIPS.*
-GPR size: .*
-CPR1 size: .*
-CPR2 size: 0
-FP ABI: Hard float \(double precision\)
-ISA Extension: None
-ASEs:
-	None
-FLAGS 1: 00000000
-FLAGS 2: 00000000
-
+#pass


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]