This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Patch: Support toc relative access to dynamic symbols from static code.
- From: Alan Modra <amodra at gmail dot com>
- To: Kyle Butt <iteratee at google dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 18 Nov 2015 13:58:51 +1030
- Subject: Re: Patch: Support toc relative access to dynamic symbols from static code.
- Authentication-results: sourceware.org; auth=none
- References: <CABeP02DtWknob5nb8k7x+NVNUnOGpCKPcmA+4HCSkgDhYYR+CA at mail dot gmail dot com> <20151118030750 dot GI8120 at bubble dot grove dot modra dot org>
On Wed, Nov 18, 2015 at 01:37:50PM +1030, Alan Modra wrote:
> On Tue, Nov 17, 2015 at 04:52:41PM -0800, Kyle Butt wrote:
> > This patch allows TOC16_* relocations to reference external global
> > symbols. Previously llvm was not emitting such accesses, but they are
> > allowed by the abi.
>
> Huh? The patch does nothing, besides making the source ugly.
I take that back. I'm not used to seeing switch statements without
braces.. However, I still don't like the idea of emitting dynamic
R_PPC64_TOC16* relocs, if that is what you're trying to do. That
doesn't make sense at all since those relocs are not handled by
glibc's ld.so. It also doesn't make sense to emit plt entries or copy
relocs for them.
--
Alan Modra
Australia Development Lab, IBM