Re: [PATCH] add a configure option for using RELRO by default

[Mike Frysinger <vapier at gentoo dot org>]

On 11 Nov 2015 00:51, Romain Geissler wrote:
> On Tue, 10 Nov 2015, Mike Frysinger wrote:
> > On 10 Nov 2015 22:16, Romain Geissler wrote:
> > > --- a/gold/configure.ac
> > > +++ b/gold/configure.ac
> > >
> > > +# Decide whether you want to set "-z relro" by default
> >
> > should be a dnl instead of a # ?
> >
> > > +ac_default_relro=unset
> 
> With dnl this comment will not be in the generated configure file. With #
> it will. For me it might help to have this comment when investigating
> issues in configure. So I let it this way. Unless you want me to really
> switch to dnl.

i think everything should be a dnl unless there's an explicit reason,
but i don't think we have a policy on this

> +esac], default_relro=unset)

would be good to quote with [] too.  applies to both configure scripts.

otherwise looks fine to me.  not sure if we want to make it default to yes
for some targets (like linux?) but we can debate that in a follow up commit.
-mike

Attachment: signature.asc
Description: Digital signature