This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC PATCH 1/4] [BFD][LD] Fix linker error when using NT weak externals
- From: Alan Modra <amodra at gmail dot com>
- To: Octavian Purdila <octavian dot purdila at intel dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 23 Oct 2015 17:06:03 +1030
- Subject: Re: [RFC PATCH 1/4] [BFD][LD] Fix linker error when using NT weak externals
- Authentication-results: sourceware.org; auth=none
- References: <1445530220-4412-1-git-send-email-octavian dot purdila at intel dot com> <1445530220-4412-2-git-send-email-octavian dot purdila at intel dot com>
On Thu, Oct 22, 2015 at 07:10:17PM +0300, Octavian Purdila wrote:
> --- a/bfd/linker.c
> +++ b/bfd/linker.c
> @@ -1354,8 +1354,8 @@ enum link_action
> static const enum link_action link_action[8][8] =
> {
> /* current\prev new undef undefw def defw com indr warn */
> - /* UNDEF_ROW */ {UND, NOACT, UND, REF, REF, NOACT, REFC, WARNC },
> - /* UNDEFW_ROW */ {WEAK, NOACT, NOACT, REF, REF, NOACT, REFC, WARNC },
> + /* UNDEF_ROW */ {UND, NOACT, NOACT, REF, REF, NOACT, REFC, WARNC },
> + /* UNDEFW_ROW */ {WEAK, WEAK, NOACT, REF, REF, NOACT, REFC, WARNC },
This change doesn't make sense at all. Strong undefined wins over
weak undefined, not the other way around as you would seem to like.
--
Alan Modra
Australia Development Lab, IBM