This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 1/3] [aarch64] Remove argument pc from disas_aarch64_insn
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: marcus dot shawcroft at gmail dot com
- Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Fri, 2 Oct 2015 12:23:57 +0100
- Subject: [PATCH 1/3] [aarch64] Remove argument pc from disas_aarch64_insn
- Authentication-results: sourceware.org; auth=none
- References: <CAFqB+Px8-V8eojj8T66_zrM6krPeGXBVLU9h+_j5yEcrk0MMJg at mail dot gmail dot com> <1443785039-24602-1-git-send-email-yao dot qi at linaro dot org>
I happen to see that argument pc is not used inside disas_aarch64_insn
at all. This patch is to remove it.
OK to apply?
opcodes:
2015-10-01 Yao Qi <yao.qi@linaro.org>
* aarch64-dis.c (disas_aarch64_insn): Remove argument PC.
(print_insn_aarch64_word): Caller updated.
---
opcodes/aarch64-dis.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index 5fec4ee..e0faeb5 100644
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -2032,8 +2032,7 @@ user_friendly_fixup (aarch64_inst *inst)
/* Decode INSN and fill in *INST the instruction information. */
static int
-disas_aarch64_insn (uint64_t pc ATTRIBUTE_UNUSED, uint32_t insn,
- aarch64_inst *inst)
+disas_aarch64_insn (uint32_t insn, aarch64_inst *inst)
{
const aarch64_opcode *opcode = aarch64_opcode_lookup (insn);
@@ -2172,7 +2171,7 @@ print_insn_aarch64_word (bfd_vma pc,
addresses, since the addend is not currently pc-relative. */
pc = 0;
- ret = disas_aarch64_insn (pc, word, &inst);
+ ret = disas_aarch64_insn (word, &inst);
if (((word >> 21) & 0x3ff) == 1)
{
--
1.9.1