This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed, PATCH] Properly convert objects between different ELF classes


On 25/09/15 13:56, H.J. Lu wrote:
+# Section copies should copy more data than there is in the input
                            ^^^^^^^^^ What do you mean by "should"?
+# (i.e. read past end of buffer)
+# We can't test this directly without valgrind, but --reverse-bytes
+# ought to use the same value.

There's a missing "not". I'll fix that and the changelog before I commit.

2,  You added a new testcase.  But you didn't check if the output
from objcopy is correct.

It checks that the error message occurs. There shouldn't be any output.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]