Re: [PATCH ARC 1/8] BFD: new ARC port

[Mike Frysinger <vapier at gentoo dot org>]

On 03 Sep 2015 14:19, Claudiu Zissulescu wrote:
> 	* archures.c: Remove support for older ARC.

usually when support for old targets are removed, you should update the
various NEWS files

> --- a/bfd/bfd-in2.h
> +++ b/bfd/bfd-in2.h
> @@ -3521,7 +3523,9 @@ pc-relative or some form of GOT-indirect relocation.  */
>    BFD_RELOC_ARM_THUMB_IMM,
>    BFD_RELOC_ARM_THUMB_SHIFT,
>  
> -/* Renesas / SuperH SH relocs.  Not all of these appear in object files.  */
> +/* Renesas / SuperH SH relocs.  Not all of these appear in object files.
> +
> +--MARKER_ARC_RELOCS_BEGIN--  */

this change makes no sense -- delete it

> +/* BFD_RELOC_ARC_8 Arc relocation.  */
> +  BFD_RELOC_ARC_8,

are these comments useful at all ?  looks like you should delete them all,
and then delete the newlines between each reloc.

> +// TODO: Make this PLT entry code be in a separate object file.
> +// TODO: This is a linker BTW, we should be able to link. :)

use /*...*/ comments only

> +/* The zeroth entry in the absolute plt entry */

GNU style says comments are full sentences (so this needs a period), and
periods have two spaces after them.  you'll need to fix in all patches.
-mike

Attachment: signature.asc
Description: Digital signature