This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Objcopy --only-keep-debug update


> From: "H.J. Lu" <hjl.tools@gmail.com>
> Date: Fri, 7 Aug 2015 19:38:39 +0200

> On Fri, Aug 7, 2015 at 8:56 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> I checked in this patch to fix it.

> PR binutils/18785
> * binutils-all/objcopy.exp: Run strip-12.
> * binutils-all/strip-12.d: New file.
> * binutils-all/strip-12.s: Likewise.

This uses the ".bss" directive which is common (no pun intended)
but not present for all ELF targets.  (I see copy-pasting for
lots of targets, maybe it wouldn't hurt to move it into
gas/read.c.)  I changed to .section .bss which still provokes
the same failure for arm-eabi and i686-linux, and also works for
cris-elf.

commit 0a77d46120137650c13091866cb93150910e1317
Author: Hans-Peter Nilsson <hp@bitrange.com>
Date:   Sat Aug 8 01:04:50 2015 +0200

    binutils-all/strip-12.s: Use ".section .bss" instead of ".bss"
    
    which isn't supported by all ELF targets.

diff --git a/binutils/testsuite/ChangeLog b/binutils/testsuite/ChangeLog
index 4f60f93..88b0d78 100644
--- a/binutils/testsuite/ChangeLog
+++ b/binutils/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-08-08  Hans-Peter Nilsson  <hp@axis.com>
+
+	* binutils-all/strip-12.s: Use ".section .bss" instead of ".bss"
+	which isn't supported by all ELF targets.
+
 2015-08-07  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR binutils/18785
diff --git a/binutils/testsuite/binutils-all/strip-12.s b/binutils/testsuite/binutils-all/strip-12.s
index 46b729f..020cecc 100644
--- a/binutils/testsuite/binutils-all/strip-12.s
+++ b/binutils/testsuite/binutils-all/strip-12.s
@@ -1,4 +1,4 @@
-	.bss
+	.section	.bss
 	.space 8
 	.section	.debug_str,"MS",%progbits,1
 	.string	""


brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]