This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix in-tree-binutils builds


On Jul 23, 2015, at 7:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Jul 17, 2015 at 7:43 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Jul 15, 2015 at 9:47 AM, Mike Stump <mrs@mrs.kithrup.com> wrote:
>>> On Jul 15, 2015, at 9:07 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> 
>>>>> -         $gcc_cv_as_gas_srcdir/configure.in \
>>>>> +         $gcc_cv_as_gas_srcdir/configure.[ai][cn] \
>>>>>         $gcc_cv_as_gas_srcdir/Makefile.in ; do
>>>>>  gcc_cv_gas_version=`sed -n -e 's/^[[         ]]*VERSION=[[^0-9A-Za-z_]]*\([[0-9]]*\.[[0-9]]*.*\)/VERSION=\1/p' < $f`
>>>> 
>>>> How portable is [ai][cn]?
>>> 
>>> Should be portable enough.
>> 
>> Are there any objections to this patch?
> 
> Can we check in this patch?

I’m not a build system nor a global reviewer so i have no more authority to say yes than you.

Seems kinda obvious and trivial to me.  The goal of fixing in-tree binutils builds seems reasonable to me.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]