This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH, MIPS] Support shared library debug with MIPS PIE
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: 'Richard Sandiford' <rdsandiford at googlemail dot com>, "'binutils at sourceware dot org'" <binutils at sourceware dot org>, "Maciej W. Rozycki (macro at linux-mips dot org)" <macro at linux-mips dot org>
- Date: Thu, 23 Jul 2015 16:55:11 +0000
- Subject: RE: [PATCH, MIPS] Support shared library debug with MIPS PIE
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B0235321175C6A at LEMAIL01 dot le dot imgtec dot org> <87381ii9iy dot fsf at googlemail dot com> <6D39441BF12EF246A7ABCE6654B0235321176D73 at LEMAIL01 dot le dot imgtec dot org> <6D39441BF12EF246A7ABCE6654B02353211AFA73 at LEMAIL01 dot le dot imgtec dot org>
On Fri, 26 Jun 2015, Matthew Fortune wrote:
> + dt_addr = (sdyn->output_section->vma + sdyn->output_offset
> + + b - sdyn->contents);
For the case of n64 target and 32-bit host, this results in
sdyn->output_section->vma + sdyn->output_offset (64-bit) being added
to b (32-bit host pointer), so losing the high part and resulting in
an incorrect DT_MIPS_RLD_MAP_REL tag, and all dynamically linked glibc
tests failing for n64. This patch fixes this (spot-tested with glibc
tests; however, I don't have a self-contained testcase for this bug).
2015-07-23 Joseph Myers <joseph@codesourcery.com>
* elfxx-mips.c (_bfd_mips_elf_finish_dynamic_sections)
<DT_MIPS_RLD_MAP_REL>: Add target address to host address
difference, not to host pointer.
diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index 9932453..06e8158 100644
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -11515,7 +11515,7 @@ _bfd_mips_elf_finish_dynamic_sections (bfd *output_bfd,
/* The MIPS_RLD_MAP_REL tag stores the offset to the debug
pointer, relative to the address of the tag. */
dt_addr = (sdyn->output_section->vma + sdyn->output_offset
- + b - sdyn->contents);
+ + (b - sdyn->contents));
rld_addr = (s->output_section->vma + s->output_offset
+ h->root.u.def.value);
dyn.d_un.d_ptr = rld_addr - dt_addr;
--
Joseph S. Myers
joseph@codesourcery.com