This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix AVX512 vcvtt?ps2u?qq instructions disassembly (Intel syntax)/18631

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: "Fomin, Alexander" <alexander dot fomin at intel dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
Date: Mon, 20 Jul 2015 05:47:56 -0700
Subject: Re: [PATCH] Fix AVX512 vcvtt?ps2u?qq instructions disassembly (Intel syntax)/18631
Authentication-results: sourceware.org; auth=none
References: <43F32C894E7D6F49862D963FA74413E225BE59 at CDSMSX102 dot ccr dot corp dot intel dot com>

On Mon, Jul 20, 2015 at 5:35 AM, Fomin, Alexander
<alexander.fomin@intel.com> wrote:
> For Intel AVX512 vcvtt?ps2u?qq instructions with broadcasting enabled,
> memory operand size should be DWORD, not QWORD.
>
> An additional Intel syntax test with memory operand and broadcasting enabled
> has been added to gas testsuite.
>
>
> gas/testsuite/gas/i386

It should be " gas/testsuite/".

>
>                 * avx512dq-intel.d: Replace âQWORDâ with âDWORDâ in

Please add gas/i386/ to file name and limit number of columns to 72.

> vcvtt?ps2u?qq instructions disassembly regexes.
>
> Add disassembly regex for new test.
>
>                 * avx512dq.d: Likewise.
>
>                 * avx512dq_vl-intel.d: Likewise.
>
>                 * avx512dq_vl.d: Likewise.
>
>                 * x86-64-avx512dq-intel.d: Likewise.
>
>                 * x86-64-avx512dq.d: Likewise.
>
>                 * x86-64-avx512dq_vl-intel.d: Likewise.
>
>                 * x86-64-avx512dq_vl.d: Likewise.
>
>                 * avx512dq.s: Add new test (Intel syntax, memory operand,
> broadcasting enabled).
>
>                 * avx512dq_vl.s: Likewise.
>
>                 * x86-64-avx512dq.s: Likewise.
>
>                 * x86-64-avx512dq_vl.s: Likewise.
>
>
>
> opcodes/
>
>                 * i386-dis-evex.h (EVEX_W_0F78_P_2): Replace âEXxmmqâ with
> âEXEvexHalfBcstXmmqâ for second operand.
>
>                 (EVEX_W_0F79_P_2): Likewise
>
>                 (EVEX_W_0F7A_P_2): Likewise
>
>                 (EVEX_W_0F7B_P_2): Likewise
>
>
>

Your mailer adds an extra blank line.  Please submit the updated patch
and make sure that your mailer doesn't change your patch.

Thanks.

H.J.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]