This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [MIPS] Reserve a .gnu_attribute value



> -----Original Message-----
> From: Maciej W. Rozycki [mailto:macro@linux-mips.org]
> Sent: Wednesday, July 08, 2015 3:07 PM
> To: Richard Sandiford
> Cc: Moore, Catherine; Richard Sandiford; binutils@sourceware.org;
> andrew.bennett@imgtec.com; Matthew Fortune
> Subject: Re: [MIPS] Reserve a .gnu_attribute value
> 
> On Wed, 8 Jul 2015, Richard Sandiford wrote:
> 
> > > diff --git a/binutils/readelf.c b/binutils/readelf.c index
> > > 398a165..86cfd26 100644
> > > --- a/binutils/readelf.c
> > > +++ b/binutils/readelf.c
> > > @@ -13197,6 +13197,9 @@ print_mips_fp_abi_value (int val)
> > >      case Val_GNU_MIPS_ABI_FP_64A:
> > >        printf (_("Hard float compat (32-bit CPU, 64-bit FPU)\n"));
> > >        break;
> > > +    case Val_GNU_MIPS_ABI_FP_NAN2008 :
> > > +      printf (_("NaN 2008 compatibility\n"));
> > > +      break;
> >
> > No space before ":"
> >
> > OK with that change, thanks.
> 
>  Shouldn't there be more case values?  `Val_GNU_MIPS_ABI_FP_NAN2008'
> was ORed with the lower bits, e.g. `Val_GNU_MIPS_ABI_FP_DOUBLE'.
> 

I'm trying to provide a minimal implementation that will ensure that Val_GNU_MIPS_ABI_FP_NAN2008 doesn't get used for anything else.  There isn't anything in the upstream repository that will generate or use that bit unless it's by mistake.  I thought it would be best to have readelf just indicate that the bit was in use.

Catherine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]