This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix handling of __start/__stop symbols
- From: Davide Italiano <dccitaliano at gmail dot com>
- To: Rafael EspÃndola <rafael dot espindola at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, Cary Coutant <ccoutant at gmail dot com>
- Date: Wed, 10 Jun 2015 08:27:25 -0700
- Subject: Re: [PATCH] Fix handling of __start/__stop symbols
- Authentication-results: sourceware.org; auth=none
- References: <CADob98S+6_r_OgvMm7LAW6ifMF=+RA9HJBy9ki4Nh+Qn8kqXCA at mail dot gmail dot com> <CAG3jReLU+QfjHWoXsvt42KUHaRQecR_NDFoSXa2vr8U7T_qZ+A at mail dot gmail dot com>
On Sun, May 31, 2015 at 2:24 PM, Rafael EspÃndola
<rafael.espindola@gmail.com> wrote:
> Ccing Cary (the gold maintainer).
>
> On May 31, 2015 4:22 PM, "Davide Italiano" <dccitaliano@gmail.com> wrote:
>>
>> If the section contains 'Q' in the name, is_cident() returns false,
>> __start and __stop symbols for the section are not generated..
>> This is likely wrong. While at it, I changed a trailing whitespace in
>> the line immediately above the one containing the typo.
>> Sorry if I missed something in the patch submission, it's my first one
>> and I'm not still really familiar with the process.
>>
>> Thanks,
>>
>> --
>> Davide
>>
>> % git diff
>> diff --git a/gold/gold.h b/gold/gold.h
>> index ef95f53..45292b7 100644
>> --- a/gold/gold.h
>> +++ b/gold/gold.h
>> @@ -255,8 +255,8 @@ inline bool
>> is_cident(const char* name)
>> {
>> return (name[strspn(name,
>> - ("0123456789"
>> - "ABCDEFGHIJKLMNOPWRSTUVWXYZ"
>> + ("0123456789"
>> + "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
>> "abcdefghijklmnopqrstuvwxyz"
>> "_"))]
>> == '\0');
Cary, any chance you can take a look at this and let me know what you think?
Thanks,
--
Davide