Re: Regression with your binutils 3e19fb8

[Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>]

> From: "H.J. Lu" <hjl.tools@gmail.com>
> Date: Fri, 24 Apr 2015 04:00:32 +0200

> On Thu, Apr 23, 2015 at 5:43 PM, Hans-Peter Nilsson
> <hans-peter.nilsson@axis.com> wrote:
> > For cris-elf:
> > Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/elf.exp ...
> > FAIL: ld-elf/compressed1e
> >
> > brgds, H-P
> 
> I checked in this.

>     Xfail cris and frv for ld-elf/compressed1e.d
> 
>     cris and frv don't support -shared.

Wrong, cris-linux supports -shared, but cris-elf doesn't.
(Usually, *-elf toolchains don't *really* support creating
shared libraries that work on the target platform.  Though, more
often than not, silently.)  There may be similarly confusion
about frv-elf vs. frv-linux, but I'll leave that to you to
investigate.

> --- a/ld/testsuite/ld-elf/compressed1e.d
> +++ b/ld/testsuite/ld-elf/compressed1e.d
> @@ -2,6 +2,8 @@
>  #as: --compress-debug-sections=none
>  #ld: -shared --compress-debug-sections=zlib-gnu
>  #readelf: -SW
> +#target: *-*-linux* *-*-gnu*
> +#xfail: cris*-*-* frv-*-*
> 
>  #failif
>  #...
> 

Also wrong.  The "xfail" is for bugs.  Use "notarget" to say
"not supported" (as in "not applicable", not because of bugs).

As I got, for cris-linux:

Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/elf.exp ...
XPASS: ld-elf/compressed1e

I then committed this:

ld/testsuite:
	* ld-elf/compressed1e.d: Correct xfail to notarget and cris*-*-*
	to cris*-*-elf.

diff --git a/ld/testsuite/ld-elf/compressed1e.d b/ld/testsuite/ld-elf/compressed1e.d
index 6e46381..fa2c93b 100644
--- a/ld/testsuite/ld-elf/compressed1e.d
+++ b/ld/testsuite/ld-elf/compressed1e.d
@@ -3,7 +3,7 @@
 #ld: -shared --compress-debug-sections=zlib-gnu
 #readelf: -SW
 #target: *-*-linux* *-*-gnu*
-#xfail: cris*-*-* frv-*-*
+#notarget: cris*-*-elf frv-*-*
 
 #failif
 #...

brgds, H-P