This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fixes for a small number of compiler warnings
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Ed Schouten <ed at nuxi dot nl>, "H.J. Lu" <hjl dot tools at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 31 Mar 2015 21:25:41 -0400 (EDT)
- Subject: Re: [PATCH] Fixes for a small number of compiler warnings
- Authentication-results: sourceware.org; auth=none
- References: <CABh_MK=meHjQHZH9Cssu3xSgsrehcar0-COMZSJf0cHZTKxH4A at mail dot gmail dot com> <20150327000715 dot GY26234 at bubble dot grove dot modra dot org> <CABh_MKmxfVGU9b=vD9yHdUWXtkN7==Ptmu4h3izQPGCzsa=b=g at mail dot gmail dot com> <CAMe9rOrys_QG+0opphc9AXn5=Z-Df4Nk0WUFTJEy-dy_ux8Y=g at mail dot gmail dot com> <CABh_MKmKPHAfVo5Q2BkBnQuGFk-x+5a3j46KtXgF9_af2UHrCg at mail dot gmail dot com> <CABh_MKnE8EBOCuTCofXi2CsWsOVq5xtC+cPqZB-NgotzKFFGLg at mail dot gmail dot com> <20150401003744 dot GN26234 at bubble dot grove dot modra dot org>
On Wed, 1 Apr 2015, Alan Modra wrote:
> On Tue, Mar 31, 2015 at 04:47:10PM +0200, Ed Schouten wrote:
> > --- a/ld/emultempl/elf32.em
> > +++ b/ld/emultempl/elf32.em
> > @@ -1412,7 +1412,7 @@ gld${EMULATION_NAME}_before_allocation (void)
> > asection *sinterp;
> > bfd *abfd;
> > struct elf_link_hash_entry *ehdr_start = NULL;
> > - struct bfd_link_hash_entry ehdr_start_save = ehdr_start_save;
> > + struct bfd_link_hash_entry ehdr_start_save = {};
> >
> > if (is_elf_hash_table (link_info.hash))
> > {
>
> Committed.
This broke most-target builds on Debian 7 / "gcc version 4.7.2
(Debian 4.7.2-5)", for example with arm-eabi (the -m32 is
unimportant):
gcc -O2 -m32 -DHAVE_CONFIG_H -I. -I/tmp/hpautotest-binutils/bsrc/src/ld -I.
-I/tmp/hpautotest-binutils/bsrc/src/ld -I../bfd -I/tmp/hpautotest-binutils/bsrc/src/ld/../bfd -I/tmp/hpautotest-binutils/bsrc/src/ld/../include -g -O2
-DENABLE_PLUGINS -DLOCALEDIR="\"/usr/local/share/locale\"" -W
-Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror
-g -O2 -MT earmelf.o -MD -MP -MF .deps/earmelf.Tpo -c -o earmelf.o earmelf.c
earmelf.c: In function 'gldarmelf_before_allocation':
earmelf.c:1448:10: error: missing initializer
[-Werror=missing-field-initializers]earmelf.c:1448:10: error: (near initialization for 'ehdr_start_save.root') [-Werror=missing-field-initializers]
cc1: all warnings being treated as errors
make[4]: *** [earmelf.o] Error 1
make[4]: Leaving directory `/tmp/hpautotest-binutils/arm-unknown-eabi/ld'
brgds, H-P