This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add XPA ASE and MIPS R5 microMIPS support
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Andrew Bennett <Andrew dot Bennett at imgtec dot com>
- Cc: "binutils\ at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 09 Mar 2015 20:00:58 +0000
- Subject: Re: [PATCH] Add XPA ASE and MIPS R5 microMIPS support
- Authentication-results: sourceware.org; auth=none
- References: <0DA23CC379F5F945ACB41CF394B9827720F811E1 at LEMAIL01 dot le dot imgtec dot org> <0DA23CC379F5F945ACB41CF394B9827720F818D4 at LEMAIL01 dot le dot imgtec dot org>
Andrew Bennett <Andrew.Bennett@imgtec.com> writes:
> +{"mfhc0", "t,G", 0x000000f4, 0xfc00ffff, WR_1|RD_C0, 0, 0, XPA, 0 },
> +{"mfhc0", "t,G,H", 0x000000f4, 0xfc00c7ff, WR_1|RD_C0, 0, 0, XPA, 0 },
> +{"mfhgc0", "t,G", 0x000004f4, 0xfc00ffff, WR_1|RD_C0, 0, 0, IVIRT|XPA, 0 },
> +{"mfhgc0", "t,G,H", 0x000004f4, 0xfc00c7ff, WR_1|RD_C0, 0, 0, IVIRT|XPA, 0 },
Genuine question: is this really "IVIRT or XPA" or "IVIRT and XPA"?
Would be good to have virt in the test if it's relevant.
Looks good otherwise. Until now it's been safe to use the r2 flag for
r3 and r5, since no instructions have been conditional on r3 or r5 alone.
This patch is the first to add a true r5 (microMIPS) instruction.
Is the idea that we'll just rely on .mips.abiflags to enforce r5ness
from now on? Even though that's more flexible long-term, maybe it
would make sense to have an r5 EF_* anyway, so that there's no gap
between R2 and R6 (which both have flags).
Thanks,
Richard