This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Committed][AArch64] Add support for :tlsdesc: and TLSDESC_ADR_PREL21


On 27 February 2015 at 01:37, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Feb 26, 2015 at 10:57:39PM +0000, Marcus Shawcroft wrote:
>>  2015-02-26  Marcus Shawcroft  <marcus.shawcroft@arm.com>
>>
>> +     * elfnn-aarch64.c (IS_AARCH64_TLSDESC_RELOC) BFD_RELOC_AARCH64_TLSDESC_ADR_PREL21 move.
>
> Please fix this overly long entry, which is missing a colon and is
> somewhat obscure.  The long line attracted my attention, then I
> wondered what a "BFD_RELOC... move" was!  "Move BFD_RELOC... test"
> would have been clearer.  Or just
>         * elfnn-aarch64.c (IS_AARCH64_TLSDESC_RELOC): Reorder R_TYPE tests.

Hi, Fixed as suggested, the entry now reads:

2015-02-26  Marcus Shawcroft  <marcus.shawcroft@arm.com>

        * elfnn-aarch64.c (IS_AARCH64_TLSDESC_RELOC): Reorder R_TYPE
        tests.
        (aarch64_tls_transition_without_check)
        (aarch64_reloc_got_type, elfNN_aarch64_final_link_relocate)
        (elfNN_aarch64_tls_relax, elfNN_aarch64_relocate_section)
        (elfNN_aarch64_gc_sweep_hook, elfNN_aarch64_check_relocs): Handle
        BFD_RELOC_AARCH64_TLSDESC_ADR_PREL21.
        * elfxx-aarch64.c (_bfd_aarch64_elf_put_addend)
        (_bfd_aarch64_elf_resolve_relocation): Likewise.
        * reloc.c (BFD_RELOC_AARCH64_TLSGD_ADR_PREL21): Define.

Cheers
/Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]