This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] readelf: handle corrupted chains better

From: Mike Frysinger <vapier at gentoo dot org>
To: Nicholas Clifton <nickc at redhat dot com>
Cc: binutils at sourceware dot org
Date: Tue, 24 Feb 2015 10:41:01 -0500
Subject: Re: [PATCH] readelf: handle corrupted chains better
Authentication-results: sourceware.org; auth=none
References: <1424761006-14664-1-git-send-email-vapier at gentoo dot org> <54EC4AE1 dot 6050805 at redhat dot com>

On 24 Feb 2015 09:56, Nicholas Clifton wrote:
> > 2015-02-24  Mike Frysinger  <vapier@gentoo.org>
> >
> > 	PR binutils/17531
> > 	* readelf.c (process_symbol_table): Declare chained.  Increment it
> > 	in every loop.  Abort when chained is larger than nchains.  Move
> > 	error check outside of chain loop.
> 
> Approved - please apply.

done

> (Thanks for doing this.  I knew that there was a better way to protect 
> against loops, but my brain just could not come up with it).

no worries ... i hit the same bug in a package i maintain so i figured i'd fix 
readelf too while i was at it
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] readelf: handle corrupted chains better
  - From: Mike Frysinger
- Re: [PATCH] readelf: handle corrupted chains better
  - From: Nicholas Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]