This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping [PATCH, h8300] Add h8300-*-linux

Hi Sato-san,


Sorry for the delay in reviewing this patch.

I have applied the patch, but there were a few minor problems that needed to be fixed:

--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,10 @@
+2015-01-21  Yoshinori Sato  <>
+	* config/tc-h8300.c (line_separater_chars): Add separator
+	* config/tc-h8300.c (md_longopts): Add '--march' option.
+	* config/tc-h8300.h: Add elf32-h8300-linux
+	* configure.tgt: Add h8300-*-linux

ChangeLog entries are normally supplied as plain text rather than context diffs, since the changelog is updated so frequently. Also the entry should include reasonably full descriptions of what has changed. The tc-h8300.c file for example had several more changes made to it than is shown above.

Also - when adding a new command line option to a target you should update the relevant assembler documentation file (gas/doc/c-h8300.texi in this case) to include details of the new option.

+++ b/ld/ChangeLog
@@ -1,3 +1,12 @@
+2015-01-21  Yoshinori Sato <>
+	* (ALL_EMULATION_SOURCES): Add new emulations.

In this case is generated from So you need to include a patch to that file and then in the changelog say:

       	* (ALL_EMULATION_SOURCES): Add new emulations.
	* Regenerate.

@@ -591,16 +591,20 @@ ALL_EMULATION_SOURCES = \
  	egld960coff.c \
  	eh8300.c \
  	eh8300elf.c \
+	eh8300elf_lnux.c \

Typo:   eh8300elf_linux.c \

+	eh8300sxlelf_linux.c \

Typo:   eh8300sxelf_linux.c \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]