This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943
- From: Nicholas Clifton <nickc at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at sergiodj dot net>, Binutils Development <binutils at sourceware dot org>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 09 Jan 2015 21:59:01 +0000
- Subject: Re: [buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943
- Authentication-results: sourceware.org; auth=none
- References: <87h9w34nso dot fsf at sergiodj dot net>
Hi Sergio,
Nick's commit:
Thanks for reporting this. I have fixed the bug with the patch below.
On a side note, I can't find Nick's message mentioning the patch on the
binutils ml.
That's because the message is in PR 17512, where a lot of the recent
patches to minor file formats can be found.
Cheers
Nick
bfd/ChangeLog
2015-01-09 Nick Clifton <nickc@redhat.com>
* tekhex.c (getvalue): Fix thinko in test for correct extraction
of value.
(getsym): Return false if there was not enough data to extract the
symbol.
diff --git a/bfd/tekhex.c b/bfd/tekhex.c
index 9444117..94b4773 100644
--- a/bfd/tekhex.c
+++ b/bfd/tekhex.c
@@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp)
*srcp = src;
*valuep = value;
- return len == 0;
+ return len == -1U;
}
static bfd_boolean
@@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp,
char * endp)
dstp[i] = 0;
*srcp = src + i;
*lenp = len;
- return TRUE;
+ return i == len;
}
static struct data_struct *