This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Jeff Law <law at redhat dot com>, binutils <binutils at sourceware dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <ian at airs dot com>
- Date: Sat, 3 Jan 2015 14:55:24 -0800
- Subject: Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources
- Authentication-results: sourceware.org; auth=none
- References: <CA+=Sn1nMV44+3jMMZ0WJQbX=KTaETk7ZC5ZzOv3K-wYdQiCPkw at mail dot gmail dot com> <5473A3D3 dot 901 at redhat dot com>
On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law <firstname.lastname@example.org> wrote:
> On 11/22/14 21:20, Andrew Pinski wrote:
>> The problem here is here is that OBJCOPY is not being set to the
>> newly built objcopy when compiling libgo. This patch adds
>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when
>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET.
>> I noticed this issue when building an aarch64 cross compile on an
>> older system where objcopy did not understand aarch64.
>> OK? Bootstrapped and tested on x86_64 with no regressions. Also
>> tested with a combined build for a cross compiler to
>> Andrew Pinski
>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also.
>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET.
>> (BASE_TARGET_EXPORTS): Add OBJCOPY.
>> (OBJCOPY_FOR_TARGET): New variable.
>> (EXTRA_TARGET_FLAGS): Add OBJCOPY.
>> * Makefile.in: Regenerate.
>> * configure.ac: Check for already installed target objcopy.
>> Also GCC_TARGET_TOOL on objcopy.
>> * configure: Regenerate.
Committed to GCC and gdb/binutils repos now.