[PATCH] [MIPS] Ensure that local GOT entries accessed via a 16-bit index come first

Maciej W. Rozycki macro@codesourcery.com
Wed Apr 16 21:43:00 GMT 2014


On Wed, 16 Apr 2014, Richard Sandiford wrote:

> This looks really good, thanks.  Just for the record, in case anyone else
> was thinking the same thing: I was a bit worried at first about using
> unsigned int for assigned_high_gotno, since it's an "end - 1" value.
> But of course it can never be negative because we always have at least
> one reserved entry before the local area.

 I've been wondering if we need to do anything special about compound 
relocs, e.g. GOT_PAGE/HI16, GOT_PAGE/LO16, etc. (aka %hi(%got_page(foo)), 
etc.) in the new ABIs, that obviously can go towards the end of the local 
GOT area.  I don't know offhand if GCC produces them for e.g. `-mabi=64 
-xgot', especially perhaps GOT_DISP/HI16 and GOT_DISP/LO16 as we shouldn't 
normally exhaust the 16-bit space for GOT_PAGE, but the ABI supports them 
in principle.

  Maciej



More information about the Binutils mailing list